登录
首页 >  Golang >  Go问答

死锁问题:goroutine 数量增加引发的通道使用冲突

来源:stackoverflow

时间:2024-03-20 21:21:29 372浏览 收藏

在使用 Go 开发 HTTP 状态检查程序时,引入通道后程序出现死锁问题,workgroup.done() 无法触发。原因是程序在接收通道值时阻塞,而通道上的范围持续到通道关闭为止。解决方法有两种:一是接收预期数量的值,二是使用 waitgroup 协调关闭通道。通过这些方法,程序可以正常运行,避免死锁问题。

问题内容

我正在使用 go 开发一个简单的 http 状态检查程序。程序一开始进行得很顺利。然后我在里面引入了channel,它就是不停止。也就是说,workgroup.done()没有被触发。

如何触发 workgroup.done()

// go playground: https://play.golang.org/p/1AzXEAV9p4K
package main

import (
    "fmt"
    "net/http"
    "runtime"
    "sync"
)

type urlState struct {
    url   string
    state bool
}

func checkLink(link string, c chan<- urlState) {
    _, err := http.Get(link)
    if err != nil {
        fmt.Println(link, `is not working`)
        c <- urlState{
            url:   link,
            state: false,
        }
    } else {
        fmt.Println(link, `is working`)
        c <- urlState{
            url:   link,
            state: true,
        }
    }
}

func Check(links []string) bool {
    result := true
    stats := make(map[string]bool)
    var wg sync.WaitGroup
    fmt.Println(`total sites: `, len(links))
    wg.Add(len(links)) // add workgroups of exactly same amount as links array length

    c := make(chan urlState, len(links))
    for _, link := range links {
        stats[link] = false
        fmt.Println(`requesting...`, link)
        go checkLink(link, c)
        fmt.Println(`goroutines: `, runtime.NumGoroutine())
    }

    for v := range c {
        fmt.Println(`recv from channel, assigning result for `, v.url)
        stats[v.url] = v.state
        wg.Done()
        fmt.Println(`goroutines: `, runtime.NumGoroutine())
    }

    wg.Wait() // any codes below are not reached. increased number of goroutines seem to be the reason. 
    close(c)
    fmt.Println(`work finished!`)
    for key, value := range stats {
        fmt.Println(key, `---`, value)
        if value == false {
            result = false
        }
    }
    return result
}

func main() {
  links := []string{`https://goolgle.com`, `https://amazon.com`} // two goroutines are expected
  Check(links) // shows increased number of goroutines. and it goes deadlock
}

解决方案


程序在 for v := range c 上阻塞,因为通道上的范围一直持续到通道关闭为止。通过接收预期数量的值来修复。此更改不需要 waitgroup。

result := true
stats := make(map[string]bool)
fmt.println(`total sites: `, len(links))

c := make(chan urlstate, len(links))
for _, link := range links {
    stats[link] = false
    fmt.println(`requesting...`, link)
    go checklink(link, c)
    fmt.println(`goroutines: `, runtime.numgoroutine())
}

for i := 0; i < len(links); i++ {
    v := <-c
    fmt.println(`recv from channel, assigning result for `, v.url)
    stats[v.url] = v.state
    fmt.println(`goroutines: `, runtime.numgoroutine())
}

fmt.println(`work finished!`)
for key, value := range stats {
    fmt.println(key, `---`, value)
    if value == false {
        result = false
    }
}

Run it on the playground

解决该问题的另一种方法是在 checklink goroutine 完成后关闭 c。使用 waitgroup 来协调这一点。

func checkLink(link string, c chan<- urlState, wg *sync.WaitGroup) {
    defer wg.Done()
    ... remainder of function is same as before
}

func Check(links []string) bool {
    result := true
    stats := make(map[string]bool)
    var wg sync.WaitGroup
    fmt.Println(`total sites: `, len(links))
    wg.Add(len(links)) // add workgroups of exactly same amount as links array length

    c := make(chan urlState, len(links))
    for _, link := range links {
        stats[link] = false
        fmt.Println(`requesting...`, link)
        go checkLink(link, c, &wg)
        fmt.Println(`goroutines: `, runtime.NumGoroutine())
    }

    // Close c when checkLink goroutines complete.
    go func() {
        wg.Wait()
        close(c)
    }()

    for v := range c {
        fmt.Println(`recv from channel, assigning result for `, v.url)
        stats[v.url] = v.state
        wg.Done()
        fmt.Println(`goroutines: `, runtime.NumGoroutine())
    }

    fmt.Println(`work finished!`)
    for key, value := range stats {
        fmt.Println(key, `---`, value)
        if value == false {
            result = false
        }
    }
    return result
}

Run it on the playground

以上就是本文的全部内容了,是否有顺利帮助你解决问题?若是能给你带来学习上的帮助,请大家多多支持golang学习网!更多关于Golang的相关知识,也可关注golang学习网公众号。

声明:本文转载于:stackoverflow 如有侵犯,请联系study_golang@163.com删除
相关阅读
更多>
最新阅读
更多>
课程推荐
更多>