登录
首页 >  Golang >  Go问答

Golang 数据竞争条件的测试用例

来源:stackoverflow

时间:2024-02-17 20:03:24 230浏览 收藏

偷偷努力,悄无声息地变强,然后惊艳所有人!哈哈,小伙伴们又来学习啦~今天我将给大家介绍《Golang 数据竞争条件的测试用例》,这篇文章主要会讲到等等知识点,不知道大家对其都有多少了解,下面我们就一起来看一吧!当然,非常希望大家能多多评论,给出合理的建议,我们一起学习,一起进步!

问题内容

所以我有一些管道。我必须逐行比较两个文件,例如加载到数据库。 我希望处理单行有一些超时,并在达到时中断管道。 输入端点是函数run()。这里我们进行一些验证并使用命令创建结构

之后,在 run() 函数中,我们开始在单个 goroutine 中处理 stdout,并在 ubuntu 中运行主进程 comm 命令。嗯,它工作得很好,我检查了它的比赛: go 构建 --racego 运行 --race。没有任何问题和输出。但我有测试,检查简单的逻辑。它工作得几乎很好,10 次运行前有 1 次失败。在我对此进行调查之后,我在这次测试中发现了竞争条件。有人可以解释一下,出了什么问题吗?

输入

func (cmwk *commworker) run(path1, path2, category, subcategory string) error {
    err := cmwk.opt.validate()
    if err != nil {
        return err
    }
    if notexistfile(path1) {
        return &aescommerror{fmt.sprintf(
            "check your file path [%s].it is invalid", path1),
        }
    }
    if isdir(path1) {
        return &aescommerror{fmt.sprintf(
            "check your file path [%s].it is invalid", path1),
        }
    }
    // if path2 does not exist, we create this file
    if notexistfile(path2) {
        err := createifnotexist(path2)
        if err != nil {
            return err
        }
    }
    cmwk.category = category
    cmwk.subcategory = subcategory
    cmwk.aescomm = newaescomm(path1, path2, cmwk.opt)
    return cmwk.run()
}
// newaescomm returns aescomm structure with described options
func newaescomm(path1, path2 string, options *aescommoptions) *aescomm {
    arguments := append(getarguments(options), path1, path2)
    return &aescomm{
        filepath1: path1,
        filepath2: path2,
        cmd:       exec.command("comm", arguments...),
    }
}
// run starts comm process with options
func (cmwk *commworker) run() error {
    stdout, err := cmwk.aescomm.stdoutpipe()
    if err != nil {
        return err
    }
    defer stdout.close()

    go cmwk.processstdout(stdout)

    return cmwk.aescomm.run()
}
// run start comm task
func (comm aescomm) run() error {
    if err := comm.cmd.start(); err != nil {
        return err
    }
    return comm.cmd.wait()
}
func (cmwk *commworker) processstdout(stdout io.readcloser) {
    scanner := bufio.newscanner(stdout)
    timer := time.newtimer(cmwk.ptimeout)
    erch := make(chan error, 1)
    for scanner.scan() {
        line := scanner.text()
        if strings.hasprefix(line, "#") {
            continue
        }
        if err := cmwk.process(line, timer, erch); err != nil {
            cmwk.interrupt(err)
            return
        }

        timer.reset(cmwk.ptimeout)
    }
    if err := cmwk.clear(erch); err != nil {
        cmwk.interrupt(err)
    }
}
func (cmwk *commworker) process(line string, timer *time.timer, erch chan error) error {
    erch <- cmwk.processor.processline(line, cmwk.category, cmwk.subcategory)
    select {
    case <-timer.c:
        return fmt.errorf("got timeout error handling line")
    default:
        return <-erch
    }
}
func (cmwk *commworker) interrupt(err error) {
    cmwk.error = err
    _ = cmwk.aescomm.cmd.process.signal(signal)
}

损坏的测试

func testcommworker_run5(t *testing.t) {
    proc := &testutils.testprocessor{fail: true, lines: []string{}} // simple test processor that fails
    createwritefile(srs, fp1)
    wk := newcommworker(&aescommoptions{checkorder: true, ptimeout: ptimeout}, proc)
    err := wk.run(fp1, fp2, testcategory, testsubcategory)
    assert.nil(t, err)
    assert.error(t, wk.err()) // race condition
}

输出

==================
WARNING: DATA RACE
Read at 0x00c00048e3a8 by goroutine 15:
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).Err()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:144 +0x4b9
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.TestCommWorker_Run5()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker_test.go:103 +0x4ca
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1123 +0x202

Previous write at 0x00c00048e3a8 by goroutine 19:
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).interrupt()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:119 +0x22e
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).processStdout()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:107 +0x219

Goroutine 15 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1168 +0x5bb
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1439 +0xa6
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1123 +0x202
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1437 +0x612
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1345 +0x3b3
  main.main()
      _testmain.go:73 +0x236

Goroutine 19 (running) created at:
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:54 +0x169
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).Run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:94 +0x4f7
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.TestCommWorker_Run5()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker_test.go:101 +0x454
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1123 +0x202
==================
--- FAIL: TestCommWorker_Run5 (0.08s)
    testing.go:1038: race detected during execution of test
==================
WARNING: DATA RACE
Read at 0x00c0005160a0 by goroutine 19:
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).interrupt()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:120 +0x2ad
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).processStdout()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:107 +0x219

Previous write at 0x00c0005160a0 by goroutine 15:
  os/exec.(*Cmd).Start()
      /usr/local/go/src/os/exec/exec.go:422 +0x8e4
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.AESComm.Run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWrapper.go:93 +0x3c
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:56 +0x1fa
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).Run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:94 +0x4f7
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.TestCommWorker_Run5()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker_test.go:101 +0x454
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1123 +0x202

Goroutine 19 (running) created at:
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:54 +0x169
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).Run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:94 +0x4f7
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.TestCommWorker_Run5()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker_test.go:101 +0x454
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1123 +0x202

Goroutine 15 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1168 +0x5bb
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1439 +0xa6
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1123 +0x202
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1437 +0x612
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1345 +0x3b3
  main.main()
      _testmain.go:73 +0x236
==================
==================
WARNING: DATA RACE
Read at 0x00c0004b5890 by goroutine 19:
  os.(*Process).signal()
      /usr/local/go/src/os/exec_unix.go:65 +0x64
  os.(*Process).Signal()
      /usr/local/go/src/os/exec.go:131 +0x2f7
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).interrupt()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:120 +0x256
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).processStdout()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:107 +0x219

Previous write at 0x00c0004b5890 by goroutine 15:
  os.newProcess()
      /usr/local/go/src/os/exec.go:25 +0x5ee
  os.startProcess()
      /usr/local/go/src/os/exec_posix.go:62 +0x668
  os.StartProcess()
      /usr/local/go/src/os/exec.go:102 +0x92
  os/exec.(*Cmd).Start()
      /usr/local/go/src/os/exec/exec.go:422 +0x8af
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.AESComm.Run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWrapper.go:93 +0x3c
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:56 +0x1fa
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).Run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:94 +0x4f7
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.TestCommWorker_Run5()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker_test.go:101 +0x454
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1123 +0x202

Goroutine 19 (running) created at:
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:54 +0x169
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.(*CommWorker).Run()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker.go:94 +0x4f7
  aesgit.devintermedia.net/aescore/sophosrs/commWrapper.TestCommWorker_Run5()
      /home/konstantin/go/src/SophosRS/commWrapper/commWorker_test.go:101 +0x454
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1123 +0x202

Goroutine 15 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1168 +0x5bb
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1439 +0xa6
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1123 +0x202
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1437 +0x612
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1345 +0x3b3
  main.main()
      _testmain.go:73 +0x236
==================
FAIL
exit status 1

解决方案


我认为问题存在于 run 产生的灌浆中。它最终调用 interrupt 写入 CommWorkerError 属性。在测试中,您生成 goroutine,然后读取 wk.Err() 属性 (wk.Err()),但不能保证生成的 goroutine 做了什么。

在检查结果之前,您需要做一些事情来确保 cmWk.processStdout(stdout) (goroutine 中的东西)绝对完成。您可以在没有 goroutine 的情况下按顺序运行它,或者可以向 CommWorker 引入 WaitGroup,goroutine 使用它来指示完成并等待测试。

以上就是《Golang 数据竞争条件的测试用例》的详细内容,更多关于的资料请关注golang学习网公众号!

声明:本文转载于:stackoverflow 如有侵犯,请联系study_golang@163.com删除
相关阅读
更多>
最新阅读
更多>
课程推荐
更多>